You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Current behaviour:
The same overrides syntax in tree-sitter is treated differently as shown in these screenshots. When it is not in the last line in the file, it is treated as the override (even though it is still picking up the content following). When it is in the last line, it is treated as an identifier and nothing related to override anymore.
Expectation:
When it encounters MYVAR:a: in the last line of the file, it still treats it as overrides or partially. This is an override statement yet to be completed and it will benefit the completion in language extension.
Good to have:
When it encounters MYVAR:a:not in the last line of the file, the current one is enough to identify an override syntax to perform further actions. But it will be nice if it won't pick up the content following as part of the override syntax.
The text was updated successfully, but these errors were encountered:
I just realized that variable expansion in override is not handled: FILES:${PN}:append = "/usr/bin/example"
It would be nice to treat it as override statement's child even in a case like this: FILES:${PN}: = "/usr/bin/example" where the second override is about to be typed after the :
tree-sitter's error recovery can't be fine tuned for specific cases, it's a general error recovery mechanism so I'm not going to fix this - but the valid variable expansion code has been fixed
Version:
1.0.1
Current behaviour:
The same overrides syntax in tree-sitter is treated differently as shown in these screenshots. When it is not in the last line in the file, it is treated as the override (even though it is still picking up the content following). When it is in the last line, it is treated as an identifier and nothing related to override anymore.
Expectation:
When it encounters
MYVAR:a:
in the last line of the file, it still treats it asoverrides
or partially. This is an override statement yet to be completed and it will benefit the completion in language extension.Good to have:
When it encounters
MYVAR:a:
not in the last line of the file, the current one is enough to identify an override syntax to perform further actions. But it will be nice if it won't pick up the content following as part of the override syntax.The text was updated successfully, but these errors were encountered: