Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong TransactionStatusCode for Security_Authenticate requests on SoapHeader v4 #271

Closed
mlamm opened this issue Nov 26, 2018 · 2 comments
Closed

Comments

@mlamm
Copy link
Contributor

mlamm commented Nov 26, 2018

The fix of #151 caused this issue.

Requests for Security_Authenticate have their TransactionStatusCode set to InSeries when attempting to start a session using that very request.

While using \Amadeus\Client::securityAuthenticate() with the appropriate \Amadeus\Client\Params this faulty xml-request is created:

XML-Request

<SOAP-ENV:Envelope xmlns:SOAP-ENV="http://schemas.xmlsoap.org/soap/envelope/"
                   xmlns:ns1="http://xml.amadeus.com/VLSSLQ_06_1_1A" xmlns:ns2="http://www.w3.org/2005/08/addressing"
                   xmlns:ns3="http://xml.amadeus.com/2010/06/Session_v3">
    <SOAP-ENV:Header>
        <ns2:MessageID>x</ns2:MessageID>
        <ns2:Action>http://webservices.amadeus.com/VLSSLQ_06_1_1A</ns2:Action>
        <ns2:To>https://nodeD1.test.webservices.amadeus.com/x</ns2:To>
        <ns3:Session TransactionStatusCode="InSeries">
            <ns3:SessionId/>
            <ns3:SequenceNumber/>
            <ns3:SecurityToken/>
        </ns3:Session>
    </SOAP-ENV:Header>
    <SOAP-ENV:Body>
        <ns1:Security_Authenticate>
            <ns1:userIdentifier>
                <ns1:originIdentification>
                    <ns1:sourceOffice>x</ns1:sourceOffice>
                </ns1:originIdentification>
                <ns1:originatorTypeCode>x</ns1:originatorTypeCode>
                <ns1:originator>x</ns1:originator>
            </ns1:userIdentifier>
            <ns1:dutyCode>
                <ns1:dutyCodeDetails>
                    <ns1:referenceQualifier>x</ns1:referenceQualifier>
                    <ns1:referenceIdentifier>x</ns1:referenceIdentifier>
                </ns1:dutyCodeDetails>
            </ns1:dutyCode>
            <ns1:systemDetails>
                <ns1:organizationDetails>
                    <ns1:organizationId>x</ns1:organizationId>
                </ns1:organizationDetails>
            </ns1:systemDetails>
            <ns1:passwordInfo>
                <ns1:dataLength>0</ns1:dataLength>
                <ns1:dataType>A</ns1:dataType>
                <ns1:binaryData>x</ns1:binaryData>
            </ns1:passwordInfo>
        </ns1:Security_Authenticate>
    </SOAP-ENV:Body>
</SOAP-ENV:Envelope>
@mlamm
Copy link
Contributor Author

mlamm commented Nov 26, 2018

I made a PR to fix this: #270

@DerMika
Copy link
Collaborator

DerMika commented Nov 28, 2018

Fixed after merging the PR above - thanks again for your help!

@DerMika DerMika closed this as completed Nov 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants