Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE 11 not supported #22

Closed
dvlpr91 opened this issue Jan 14, 2020 · 6 comments
Closed

IE 11 not supported #22

dvlpr91 opened this issue Jan 14, 2020 · 6 comments
Labels
enhancement New feature or request

Comments

@dvlpr91
Copy link

dvlpr91 commented Jan 14, 2020

error occured

...
for (var tag of laravelTrixInstanceStyles) {
...

what the for ... of

@dvlpr91
Copy link
Author

dvlpr91 commented Jan 14, 2020

te7a-houdini/laravel-trix/resources/views/trixassets.blade.php

for (var tag of laravelTrixInstanceStyles) {
to
for (var tag in laravelTrixInstanceStyles) {

@amaelftah amaelftah added the enhancement New feature or request label Jan 14, 2020
@amaelftah
Copy link
Owner

fixed in v2

@dvlpr91
Copy link
Author

dvlpr91 commented Apr 29, 2020

Hey!!!!!!!!

fixed in v2.0.0.

But, it came back again in v2.0.1.

why?

@amaelftah
Copy link
Owner

@dvlpr91 it caused this issue #26

@dvlpr91
Copy link
Author

dvlpr91 commented Apr 29, 2020

Did you change only "of" to "in"?

I am not good at English, so please understand that I am using a translator.

I write the code for normal operation below as much as possible.

FROM

...
for (var tag of laravelTrixInstanceStyles) {
  style.innerHTML += tag.textContent + ' ';
}
...

TO

...
for (var i = 0; i < laravelTrixInstanceStyles.length; i++) {
  style.innerHTML += laravelTrixInstanceStyles[i].textContent + ' ';
}
...

OR

for (var i in laravelTrixInstanceStyles) {
  if (i < laravelTrixInstanceStyles.length) {
      style.innerHTML += laravelTrixInstanceStyles[i].textContent + ' ';
  }
}

I didn't check, but I simply wrote the code, thinking about the difference between "in" and "of" in javascript.

Try it.

@amaelftah
Copy link
Owner

@dvlpr91 no problems . ok i got it now . i will reopen the issue and we can convert to normal for loop

@amaelftah amaelftah reopened this Apr 29, 2020
@dvlpr91 dvlpr91 closed this as completed Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants