Skip to content

Signals with private names #1223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
whitequark opened this issue Mar 22, 2024 · 4 comments · Fixed by #1234
Closed

Signals with private names #1223

whitequark opened this issue Mar 22, 2024 · 4 comments · Fixed by #1234

Comments

@whitequark
Copy link
Member

In some cases it is desirable to create a signal with a name that doesn't show up in the waveform viewer, such as when a signal is created to hold the results of intermediate computations, or to change shape, and it would just add noise. I propose adding a notion of a "private signal name".

I suggest changing naming rules so that Signal(name="") creates a signal with a private name. Such a signal is translated to a private wire in RTLIL (with a $\d+ name), doesn't get displayed in the waveform viewer, and so on.


The FSM ongoing signals (not the state signal) should be changed to have private names in the 0.5 milestone.

@whitequark whitequark added this to the 0.5 milestone Mar 22, 2024
@tpwrules
Copy link
Contributor

tpwrules commented Mar 22, 2024

Would this also be the default for some signals generated by Amaranth, or would a user have to create such a private signal explicitly?

@whitequark whitequark mentioned this issue Mar 22, 2024
77 tasks
@whitequark
Copy link
Member Author

Would this also be the default for some signals generated by Amaranth

Only the ones that are implementation details (currently just with m.FSM() but I think we might have others later).

@tpwrules
Copy link
Contributor

I think this should be straightforward, I will try to cook up an implementation this weekend and update by Monday.

@whitequark
Copy link
Member Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants