-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zero-length submodule name breaks things #1209
Comments
Upon further consideration it's probably best to reject "" as an invalid name rather than try to do something magic with it. |
I was actually thinking that this proposal seems OK. In fact, if you do |
The specific situation I had in mind was that if you do I'm fine with the concept of unnamed modules, but if you accidentally make |
That's a good point, I forgot |
This is semantically ambiguous and breaks the RTLIL emitter. Fixes amaranth-lang#1209.
This is semantically ambiguous and breaks the RTLIL emitter. Fixes #1209.
The following design:
gives the following exception:
I suggest that
m.submodules[""] = ...
have the same behavior asm.submodules += ...
. While it would be silly to directly write the former, it might arise from programmatic name generation, and should either work properly or immediately throw an error.The text was updated successfully, but these errors were encountered: