Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow a custom filter function instead of glob #41

Closed
callumlocke opened this issue Jan 12, 2015 · 3 comments
Closed

Allow a custom filter function instead of glob #41

callumlocke opened this issue Jan 12, 2015 · 3 comments

Comments

@callumlocke
Copy link
Contributor

  1. I want to be able to pass a custom function that examines filenames and returns true/false
  2. I propose renaming the glob option to filter (and keeping glob as an alias, for back compatibility)

let me know if you agree with one or both of the above, and I'll PR!

@amasad
Copy link
Owner

amasad commented Jan 12, 2015

Would love to pull, but let's make it a filter function in addition to glob, I don't like overloading the same arg with multiple types

@callumlocke
Copy link
Contributor Author

ok 👍

@callumlocke callumlocke changed the title Allow a custom glob function Allow a custom filter function instead of glob Jan 12, 2015
@stefanpenner
Copy link
Collaborator

We are still open for a pull request, but as this as this has gone stale I will close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants