Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remaining Minor UI Fixes #33

Open
vaskaloidis opened this issue Feb 23, 2017 · 0 comments
Open

Remaining Minor UI Fixes #33

vaskaloidis opened this issue Feb 23, 2017 · 0 comments

Comments

@vaskaloidis
Copy link
Contributor

vaskaloidis commented Feb 23, 2017

  • Fix the issue with the back button JS bug on the funnel-builder: that initially breaks the campaign dropdown (on the right side column) of the homepage table - whenever you hit the back button from the FB to the homepage. If you refresh the page it fixes it, so we might force a refresh once we hit the back button

The Navbar issue: (because of Shopify API limitations) the navbar cannot properly highlight the selected page's nav-bar button, when the navbar's code is abstracted out into a Partial. Because of this, we had to manually copy the code for the navbar onto the header of each page. So whenever its modified, every page with a navbar needs to get modified and updated as well. So:

  • We need to either sync all the various navbar code to make sure they all match, and verify this is done correctly before release
  • Or we need to find a solution to this issue, and fix the problem so we can place it back into a partial. This NEEDS to happen

Fix the asset craziness in application.html.erb and embedded.html.erb in the layouts folder. One is using application.js which implements the jquery ruby gem (no idea which version), but then underneath the call (in application.html.erb) to include application.js, we re-declare a different jquery lib from a CDN.

  • We need to move all the Javascript tags to external libs, into the application.js file, and use the require tag to call them properly.
  • We need to figure out which version of JQuery is required, and remove the other ones that are loaded from Gems. Then remove those Gems, and stick with the JQuery libs from CDN that are the actual jquery versions we need for various other javascript libraries.
  • Clean up application.html.erb, embedded.html.erb and application.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants