Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster multirng logic #337

Merged
merged 5 commits into from
Feb 29, 2024
Merged

Faster multirng logic #337

merged 5 commits into from
Feb 29, 2024

Conversation

daniel-klein
Copy link
Contributor

Pure numpy results in a significant speed boost without scientific sacrifice compared to the previous pandas-based approach.

@cliffckerr
Copy link
Contributor

Cool, will take a look tomorrow!

@cliffckerr
Copy link
Contributor

See also discussion here: #335

Copy link
Contributor

@cliffckerr cliffckerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is definitely a Pareto-optimal improvement over the previous version, so let's merge it now which will also help clarify whether or not there is a benefit from further refactoring.

@cliffckerr cliffckerr merged commit a88795b into main Feb 29, 2024
2 checks passed
@cliffckerr cliffckerr deleted the faster_multirng branch February 29, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants