Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in passing arguments when generating summaries in gen_summ #3

Open
avshalomman opened this issue Nov 20, 2022 · 1 comment
Open

Comments

@avshalomman
Copy link

Hi and thanks for publishing this work online.
In case someone fails generating summaries, there is a bug in the generating script.

If you're using the non default misc dir (that is, different than ../data/misc), you will encounter an issue when trying to create the BPE Encoder.

The fix is to add the mis_dir argument to the from_pretrained call:

model = Sum.from_pretrained(task="abs_task",
                                checkpoint_file=model_checkpoint_path,
                                gpt2_encoder_json=enc_path,
                                gpt2_vocab_bpe=vocab_path, bpe='gpt2',
                                misc_dir=misc_path, <<< add this
                                dict_dir=misc_path)
@abrazinskas
Copy link
Contributor

Hello Avshalom,

Thank you for pointing this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants