Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [Improvement] don't hardcode path to bash #109

Closed
jhheider opened this issue May 25, 2024 · 2 comments · Fixed by #110
Closed

✨ [Improvement] don't hardcode path to bash #109

jhheider opened this issue May 25, 2024 · 2 comments · Fixed by #110

Comments

@jhheider
Copy link

While it's true that /bin/bash in compiler.rs is a nearly foolproof method, certain environment managers, like pkgx, may provide bash on a system on which it is not otherwise globally installed. Either trusting the path, or calling /usr/bin/env bash -c ... allows for a wider variety of supported shells.

Extremely minor issue, to be sure, but something I came across while packaging the compiler.

@github-project-automation github-project-automation bot moved this to 🆕 New in Amber Project May 25, 2024
@Ph0enixKM Ph0enixKM moved this from 🆕 New to 📋 Todo in Amber Project May 25, 2024
@Ph0enixKM Ph0enixKM changed the title [Improvement] don't hardcode path to bash ✨ [Improvement] don't hardcode path to bash May 25, 2024
@sweetbbak
Copy link

Yea, this will also fail on NixOS, whereas '#!/usr/bin/env bash' will not. env being the only binary accessible in /usr/bin on NixOS.

@Ph0enixKM
Copy link
Member

@sweetbbak this issue will be solved in #110 (review)

@Ph0enixKM Ph0enixKM linked a pull request May 25, 2024 that will close this issue
@b1ek b1ek closed this as completed in #110 May 30, 2024
@github-project-automation github-project-automation bot moved this from 📋 Todo to 🏁 Done in Amber Project May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants