Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 Fix the std trim function #135

Closed
Ph0enixKM opened this issue May 31, 2024 · 0 comments · Fixed by #158
Closed

🐞 Fix the std trim function #135

Ph0enixKM opened this issue May 31, 2024 · 0 comments · Fixed by #158
Assignees

Comments

@Ph0enixKM
Copy link
Member

Ph0enixKM commented May 31, 2024

This current function

pub fun trim(text: Text): Text {
    return unsafe $echo "{text}" | xargs$
}

also removes spaces between the words.

image

The proposed solution to this problem is to implement trim like so:

trim_left()
trim_right()
@Ph0enixKM Ph0enixKM changed the title Fix the std trim function 🐞 Fix the std trim function Jun 4, 2024
@Ph0enixKM Ph0enixKM linked a pull request Jun 7, 2024 that will close this issue
@Ph0enixKM Ph0enixKM self-assigned this Jun 7, 2024
@b1ek b1ek closed this as completed in #158 Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant