-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Migrate validity.rs test to pure Amber files #292
Comments
@Mte90 I disagree. The validity tests are for compiler developers. They already know how rust works and probably expect something that is more idiomatic to Rust projects. I also don't see the reason to do that - also because testing stdlib now takes forever (like 2-5 minutes) when we have separated the files out. And the validity completes in 5 seconds |
its a synchronous testing issue. cargo test by default splits them out to multiple threads, and we can split them out into different threads with little to no effort |
We can do that. But I still don’t understand why should de separate the validity tests |
Because we are talking about a new language, with tests inside a Rust files it is required to escape everything, the readability is bad. PHP, PYthon and other languages doesn't include this tests in C files as example https://github.com/php/php-src/tree/master/tests/func |
Okay then. But the PR should also improve the performance of the tests as well |
Like as we did for stdlib also that file need that "cure".
After the merge of #291 we can work also on this one.
The text was updated successfully, but these errors were encountered: