-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Improve whitespace consistency in standard library and integration tests #523
Comments
There was the plan to do a static code analysis in Amber but first it is needed a LSP that is in progress. Maybe in the meantime we can do a Bash script that fix those stuff. |
I think you're talking about writing some sort of linter/formatter? I was thinking to just make a one-off change, and leave the modified scripts as an exemplar for ongoing changes. |
I think that we need something that let us also after months to keep the consistency, so not just once. |
Fair enough, but that's outside the scope of the change I wanted to make. If there are no objections from anyone on my proposal, I will go ahead and raise a PR. |
I would also like to replace "Succeded" with "Succeeded" while I'm at it. |
Is your feature request related to a problem? Please describe.
I note that most of the examples of Bash command fragments in the standard library and integration tests look like:
When reading this, the average person will tokenise on spaces, reading
$echo
as a single token, and the average Bash user will probably interpret that as "the value of theecho
environment variable".Describe the solution you'd like
In the absence of an official style guide, I would like to change all the standard library functions and integration tests to something like this, and fix up any inconsistent indentation while I'm at it:
This might seem like a small request, but it's simple to do, and may improve our development lives that tiny bit.
Describe alternatives you've considered
N/A
Additional context
If we do this, we should probably make similar changes to the documentation as well.
The text was updated successfully, but these errors were encountered: