Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: gitpod ready #38

Merged
merged 2 commits into from
Nov 28, 2020
Merged

build: gitpod ready #38

merged 2 commits into from
Nov 28, 2020

Conversation

ivelin
Copy link
Contributor

@ivelin ivelin commented Nov 28, 2020

gitpod readiness

@commit-lint
Copy link

commit-lint bot commented Nov 28, 2020 •
edited
Loading

Build System

Bug Fixes

Contributors

ivelin

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

ivelin
ivelin commented Nov 28, 2020
View reviewed changes
src/peerjs/ext/http-proxy.py
@@ -162,9 +162,6 @@ async def peer_disconnected(peerId):
'Resetting to last known ID.')
peer._id = savedPeerId
peer._lastServerId = savedPeerId
global _is_shutting_down
if not _is_shutting_down:
await peer.reconnect()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reconnecting while peer is being destroyed causes an endless loop. Leave reconnect to the make_discoverable() coro.

@ivelin ivelin merged commit 12a4365 into ambianic:master Nov 28, 2020
ivelin pushed a commit that referenced this pull request Nov 28, 2020
@semantic-release-bot
chore(release): 1.4.1 [skip ci]
0c50bcf 
## [1.4.1](v1.4.0...v1.4.1) (2020-11-28)

### Bug Fixes

* merge pull request [#38](#38) from ivelin/master ([12a4365](12a4365))
* peer reconnect error; closes [#31](#31) ([6b68cfa](6b68cfa))
@ivelin
Copy link
Contributor Author

ivelin commented Nov 28, 2020

🎉 This PR is included in version 1.4.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

github-actions bot pushed a commit to ivelin/peerjs-python that referenced this pull request Sep 21, 2021
@semantic-release-bot
chore(release): 1.4.1 [skip ci]
8d30ff5 
## [1.4.1](v1.4.0...v1.4.1) (2021-09-21)

### Bug Fixes

* allow more lenient peers id load ([1fe71b6](1fe71b6)), closes [ambianic#51](https://github.com/ivelin/peerjs-python/issues/51)
* allow more lenient peers id load ([981ae27](981ae27))
* load peer ID from an empty file ([4cfe6fb](4cfe6fb)), closes [ambianic#52](https://github.com/ivelin/peerjs-python/issues/52)
* load peer ID from an empty file ([b9ff9fa](b9ff9fa))
* log_level not found in config ([fb0a2da](fb0a2da)), closes [ambianic#53](https://github.com/ivelin/peerjs-python/issues/53)
* log_level not found in config ([ddfedea](ddfedea))
* merge pull request [ambianic#38](https://github.com/ivelin/peerjs-python/issues/38) from ivelin/master ([12a4365](12a4365))
* peer reconnect error; closes [ambianic#31](https://github.com/ivelin/peerjs-python/issues/31) ([6b68cfa](6b68cfa))
* rename http-proxy to http_proxy ([8ee5e0b](8ee5e0b)), closes [ambianic#50](https://github.com/ivelin/peerjs-python/issues/50)
ivelin pushed a commit that referenced this pull request Sep 24, 2021
@semantic-release-bot
build: update CI release script (#56)
e9cd36a 
* build: update deps versions

* build: test sem rel action

* build: update access tokens

* build: sem rel fix

* build: sem rel

* build: test new script

Signed-off-by: ivelin <ivelin@ambianic.ai>

* chore(release): 1.4.1 [skip ci]

## [1.4.1](ivelin/peerjs-python@v1.4.0...v1.4.1) (2021-09-21)

### Bug Fixes

* allow more lenient peers id load ([1fe71b6](ivelin@1fe71b6)), closes [#51](https://github.com/ivelin/peerjs-python/issues/51)
* allow more lenient peers id load ([981ae27](ivelin@981ae27))
* load peer ID from an empty file ([4cfe6fb](ivelin@4cfe6fb)), closes [#52](https://github.com/ivelin/peerjs-python/issues/52)
* load peer ID from an empty file ([b9ff9fa](ivelin@b9ff9fa))
* log_level not found in config ([fb0a2da](ivelin@fb0a2da)), closes [#53](https://github.com/ivelin/peerjs-python/issues/53)
* log_level not found in config ([ddfedea](ivelin@ddfedea))
* merge pull request [#38](https://github.com/ivelin/peerjs-python/issues/38) from ivelin/master ([12a4365](ivelin@12a4365))
* peer reconnect error; closes [#31](https://github.com/ivelin/peerjs-python/issues/31) ([6b68cfa](ivelin@6b68cfa))
* rename http-proxy to http_proxy ([8ee5e0b](ivelin@8ee5e0b)), closes [#50](https://github.com/ivelin/peerjs-python/issues/50)

* build: test new script

Signed-off-by: ivelin <ivelin@ambianic.ai>

* build: test new script

Signed-off-by: ivelin <ivelin@ambianic.ai>

* fix: test new script

Signed-off-by: ivelin <ivelin@ambianic.ai>

* chore(release): 1.4.2 [skip ci]

## [1.4.2](ivelin/peerjs-python@v1.4.1...v1.4.2) (2021-09-21)

### Bug Fixes

* test new script ([5090913](ivelin@5090913))

Co-authored-by: semantic-release-bot <semantic-release-bot@martynus.net>
ivelin pushed a commit that referenced this pull request Oct 5, 2021
@semantic-release-bot
feat: support for HTTP PUT method (#57)
fdb1ac5 
* build: update deps versions

* build: test sem rel action

* build: update access tokens

* build: sem rel fix

* build: sem rel

* build: test new script

Signed-off-by: ivelin <ivelin@ambianic.ai>

* chore(release): 1.4.1 [skip ci]

## [1.4.1](ivelin/peerjs-python@v1.4.0...v1.4.1) (2021-09-21)

### Bug Fixes

* allow more lenient peers id load ([1fe71b6](ivelin@1fe71b6)), closes [#51](https://github.com/ivelin/peerjs-python/issues/51)
* allow more lenient peers id load ([981ae27](ivelin@981ae27))
* load peer ID from an empty file ([4cfe6fb](ivelin@4cfe6fb)), closes [#52](https://github.com/ivelin/peerjs-python/issues/52)
* load peer ID from an empty file ([b9ff9fa](ivelin@b9ff9fa))
* log_level not found in config ([fb0a2da](ivelin@fb0a2da)), closes [#53](https://github.com/ivelin/peerjs-python/issues/53)
* log_level not found in config ([ddfedea](ivelin@ddfedea))
* merge pull request [#38](https://github.com/ivelin/peerjs-python/issues/38) from ivelin/master ([12a4365](ivelin@12a4365))
* peer reconnect error; closes [#31](https://github.com/ivelin/peerjs-python/issues/31) ([6b68cfa](ivelin@6b68cfa))
* rename http-proxy to http_proxy ([8ee5e0b](ivelin@8ee5e0b)), closes [#50](https://github.com/ivelin/peerjs-python/issues/50)

* build: test new script

Signed-off-by: ivelin <ivelin@ambianic.ai>

* build: test new script

Signed-off-by: ivelin <ivelin@ambianic.ai>

* fix: test new script

Signed-off-by: ivelin <ivelin@ambianic.ai>

* chore(release): 1.4.2 [skip ci]

## [1.4.2](ivelin/peerjs-python@v1.4.1...v1.4.2) (2021-09-21)

### Bug Fixes

* test new script ([5090913](ivelin@5090913))

* chore: checkpoint

Signed-off-by: ivelin <ivelin@ambianic.ai>

Co-authored-by: semantic-release-bot <semantic-release-bot@martynus.net>
github-actions bot pushed a commit that referenced this pull request Oct 5, 2021
@semantic-release-bot
chore(release): 1.5.0 [skip ci]
3328eb1 
# [1.5.0](v1.4.5...v1.5.0) (2021-10-05)

### Features

* support for custom device display name ([d417830](d417830))
* support for HTTP PUT method ([#57](#57)) ([fdb1ac5](fdb1ac5)), closes [#51](#51) [#52](#52) [#53](#53) [#38](#38) [#31](#31) [#50](#50)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ivelin