Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of _parse_move no longer allows key of port as origin #176

Open
gyger opened this issue Feb 19, 2023 · 1 comment
Open

Addition of _parse_move no longer allows key of port as origin #176

gyger opened this issue Feb 19, 2023 · 1 comment

Comments

@gyger
Copy link
Contributor

gyger commented Feb 19, 2023

Hej,
with the use of _parse_move added in #c1a79f56e22b0ec22a982a4417bf27ef67620f6a it is no longer possible to use a portname in the move command.
I guess that is known, just wanted to note it was quite convenient to use, because I would be able to write in one line.

D.add_ref(device).move(origin=1, destination=otherdevice.ports[2])

but no worries if that is a design decision.

@amccaugh
Copy link
Owner

amccaugh commented Feb 22, 2023

That's interesting, I hadn't used that feature much myself but I can see the utility. From a pure design view, it makes sense not to have that functionality. For instance, if a port in my device was named [3,5] then the following command becomes ambiguous:

D.move(origin = [3,5], destination = [9,9])

But I think that's seriously an edge case. I'd be happy to add that functionality back in, I think there only needs to be two minor changes to the code for Device and DeviceReference

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants