-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add configure-time flag to skip parent_prefix_path #115
add configure-time flag to skip parent_prefix_path #115
Conversation
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
Using this modified template the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passes a visual inspection. Getting set up to test these changes in a workspace.
I built modified ament_package and ros_workspace debs, using the former when building the latter, and then pushed that modified ros_workspace deb to the container I did my tests in with this result:
|
Fast-forwarded the squashed commit from |
* move lines Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com> * check for USE_PARENT_PREFIX_PATH Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
* [windows] fix _ament_python_executable fallback code path (#113) Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com> * add configure-time flag to skip parent_prefix_path (#115) * move lines Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com> * check for USE_PARENT_PREFIX_PATH Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
Related to ros2/ros2#929.
The diff is best looked at while ignoring indentation changes: https://github.com/ament/ament_package/pull/115/files?w=1
No CI since this isn't covered by it anyway but needs to be manually verified.