Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "consider condition for group membership" #70

Merged
merged 1 commit into from
Feb 17, 2018

Conversation

mikaelarguedas
Copy link
Contributor

@mikaelarguedas mikaelarguedas commented Feb 17, 2018

Reverts #69

This broke master

See: https://ci.ros2.org/view/nightly/job/nightly_linux_debug/lastFailedBuild/ and other nightlies

@mikaelarguedas mikaelarguedas added in progress Actively being worked on (Kanban column) in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Feb 17, 2018
@mikaelarguedas mikaelarguedas self-assigned this Feb 17, 2018
@mikaelarguedas mikaelarguedas merged commit 787b892 into master Feb 17, 2018
@mikaelarguedas mikaelarguedas deleted the revert-69-fix_group_membership branch February 17, 2018 07:36
@mikaelarguedas mikaelarguedas removed the in review Waiting for review (Kanban column) label Feb 17, 2018
dirk-thomas added a commit that referenced this pull request Feb 17, 2018
@dirk-thomas
Copy link
Contributor

Thank you for fixing master quickly. It turns out this required a PR on another repo which I didn't create a PR for before: ament/ament_tools#178.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants