Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keep using default ignore list #96

Merged
merged 1 commit into from
Oct 8, 2019
Merged

keep using default ignore list #96

merged 1 commit into from
Oct 8, 2019

Conversation

dirk-thomas
Copy link
Contributor

@dirk-thomas dirk-thomas commented Oct 8, 2019 •
edited
Loading

Follow up of #89. Fixes linter warning.

@dirk-thomas
keep using default ignore list
ce02702 
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
@dirk-thomas dirk-thomas added bug Something isn't working in review Waiting for review (Kanban column) labels Oct 8, 2019
@dirk-thomas dirk-thomas self-assigned this Oct 8, 2019
@wjwwood wjwwood mentioned this pull request Oct 8, 2019
Closed
wjwwood
wjwwood approved these changes Oct 8, 2019
View reviewed changes
Copy link
Contributor

@wjwwood wjwwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you run CI yet?

I'll approve it in the interest of getting CI green again, though I don't understand the change. I assume you reproduced it locally and it actually fixes the issue.

.flake8 Show resolved Hide resolved
@dirk-thomas
Copy link
Contributor Author

Have you run CI yet?

No, due to the nature of the change I don't think it makes sense to run CI builds on Jenkins for this.

I assume you reproduced it locally and it actually fixes the issue.

Yes.

@wjwwood
Copy link
Contributor

wjwwood commented Oct 8, 2019 •
edited
Loading

No, due to the nature of the change I don't think it makes sense to run CI builds on Jenkins for this.

To see if it fixes the linter error it purports to fix? I'm ok with going without CI I guess, but it only needs to go up to ament_package, so it would be quite trivial to test.

@dirk-thomas
Copy link
Contributor Author

Before:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

After:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@dirk-thomas dirk-thomas merged commit 570df24 into master Oct 8, 2019
@delete-merged-branch delete-merged-branch bot deleted the dirk-thomas/fix-flake8-warning branch October 8, 2019 22:56
dirk-thomas added a commit that referenced this pull request Oct 10, 2019
@dirk-thomas
keep using default ignore list (#96)
e041278 
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
(cherry picked from commit 570df24)
dirk-thomas added a commit that referenced this pull request Oct 10, 2019
@dirk-thomas
keep using default ignore list (#96)
1b4034a 
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
(cherry picked from commit 570df24)
dirk-thomas added a commit that referenced this pull request Oct 10, 2019
@dirk-thomas
keep using default ignore list (#96)
dd0437e 
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
(cherry picked from commit 570df24)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjwwood wjwwood wjwwood approved these changes

Assignees

@dirk-thomas dirk-thomas

Labels
bug Something isn't working in review Waiting for review (Kanban column)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dirk-thomas @wjwwood