Use Git to fetch upstream uncrustify source code #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is somewhat of a lateral move in general, but the patching solution implemented in ec709bb can fail under certain circumstances if the target directory is not a git repository. Since the patching solution requires git anyway, and we're downloading what should be the exact same files, there should be no reason that this wouldn't work in largely the same way the current tarball-based solution does. Signed-off-by: Scott K Logan <logans@cottsay.net>
clalancette
approved these changes
Jan 6, 2021
This was referenced Jan 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is somewhat of a lateral move in general, but the patching solution implemented in #15 can fail under certain circumstances if the target directory is not a git repository.
Since the patching solution requires git anyway, and we're downloading what should be the exact same files, there should be no reason that this wouldn't work in largely the same way the current tarball-based solution does.