Update to Uncrustify v0.68.1 #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 19, 2018
|
Test CI (where uncrustify issues originally manifested themselves):
CI without macOS and Windows updates (linter tests only):
cppcheck errors are unrelated, with proposed solution in ament/ament_lint#117 |
jacobperron
added
in review
|
@jacobperron all PRs look good, it'd be great to have a green CI with those though. |
This was referenced Dec 19, 2018
|
Again with additional PRs for rcl, rclcpp, rviz, and rcl_interfaces:
|
sloretz
approved these changes
Dec 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #2
Resolves ros2/rosidl#340
There will be several connecting PRs related to resolving the linked issue.