Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

fix(workflows): removed greeting action #103

Merged
merged 2 commits into from
Apr 9, 2020

Conversation

NarmeenNaveedAhmed
Copy link
Contributor

Description

Motivation and Context

How Has This Been Tested?

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • These changes should be applied to a maintenance branch.
  • This change requires cross browser checks.
  • Performance tests should be ran against the server prior to merging.
  • This change impacts caching for client browsers.
  • This change impacts HTTP headers.
  • This change adds additional environment variable requirements for One App users.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using One App?

@NarmeenNaveedAhmed NarmeenNaveedAhmed requested review from a team as code owners April 9, 2020 16:25
@oneamexbot
Copy link
Contributor

oneamexbot commented Apr 9, 2020

📊 Bundle Size Report

file name size on disk gzip
app.js 112.6KB 31.4KB
runtime.js 15KB 5.3KB
vendors.js 128.1KB 37.9KB
app~vendors.js 405.9KB 106KB
legacy/app.js 119.4KB 33KB
legacy/runtime.js 15KB 5.3KB
legacy/vendors.js 163KB 44.8KB
legacy/app~vendors.js 412KB 107.6KB

Generated by 🚫 dangerJS against d5be9f7

@@ -7520,4 +7520,4 @@
}
}
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you remove these from the PR ?

@mtomcal mtomcal requested review from JAdshead and mtomcal April 9, 2020 18:23
@JAdshead JAdshead merged commit 663fc0c into master Apr 9, 2020
@JAdshead JAdshead deleted the chore/remove-greeting-action branch April 9, 2020 21:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants