Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

fix(serve-module): dev cdn would fail to start when serving modules without a legacy bundle #1344

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

10xLaCroixDrinker
Copy link
Member

Description

Update @americanexpress/one-app-server-bundler to 1.0.3

Motivation and Context

See americanexpress/one-app-cli#629

How Has This Been Tested?

Validated manually by @code-forger

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update
  • Security update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • These changes should be applied to a maintenance branch.
  • This change requires cross browser checks.
  • Performance tests should be ran against the server prior to merging.
  • This change impacts caching for client browsers.
  • This change impacts HTTP headers.
  • This change adds additional environment variable requirements for One App users.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using One App?

Will be able to serve modules without legacy bundle

…ithout a legacy bundle

Update  @americanexpress/one-app-server-bundler to 1.0.3
Copy link
Contributor

Size Change: 0 B

Total Size: 735 kB

ℹ️ View Unchanged
Filename Size
./build/app/app.js 187 kB
./build/app/app~vendors.js 411 kB
./build/app/runtime.js 7.07 kB
./build/app/service-worker-client.js 7.25 kB
./build/app/vendors.js 123 kB

compressed-size-action

@PixnBits PixnBits requested a review from a team March 26, 2024 19:21
@10xLaCroixDrinker 10xLaCroixDrinker enabled auto-merge (squash) March 26, 2024 19:25
@10xLaCroixDrinker 10xLaCroixDrinker merged commit 4cd972f into main Mar 26, 2024
10 checks passed
@10xLaCroixDrinker 10xLaCroixDrinker deleted the bugfix/serve-module branch March 26, 2024 19:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants