You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on May 3, 2024. It is now read-only.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
after generating a module, running npm run watch:build and serving it locally in One App, the follow error would appear:
log: Failed to load Holocron module at [one-app-dev-cdn-url]/static/modules/my-module/1.0.0/yeehaw.node.js
log: Error: only absolute urls are supported
this fix replaces the static [one-app-dev-cdn-url] string and replaces it with the actual ip and port when pulling from the module map.
Note: The module still loaded successfully before this fix - this is specifically to mitigate the error in the console.
What is the communication plan for this change?
None, just fixes a console error when watching a reloading module changes
Does any documentation need to be updated or added to account for this change? If so was it done already?
No, change is in line with current documentation
What is the motivation for this change?
To mitigate console errors
Should these changes also be applied to a maintenance branch or any other long lived branch?
No
How was this change tested?
Wrote unit tests to validate module replacing dynamic url from module map
Does this change require cross browser checks? Why or why not?
No, local development fix only
Does this change require a performance test prior to merging? Why or why not?
No, local development fix only
Could this be considered a breaking change? Why or why not?
No, local development fix only
Does the change impact caching?
No, local development fix only
Does the change impact HTTP headers?
No, local development fix only
Does the change have any new infrastructure requirements?
No, local development fix only
Does the change affect other versions of the app?
No, local development fix only
Does the change require additional environment variables?
No, local development fix only
What is the impact to tenants?
Less unnecessary errors in console
What is the impact to individual users?
No, local development fix only
What is the change to the size of assets?
None, local development fix only
Should integration tests be added to protect against future regressions on this change?
No, local development fix only
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
after generating a module, running
npm run watch:build
and serving it locally in One App, the follow error would appear:this fix replaces the static [one-app-dev-cdn-url] string and replaces it with the actual ip and port when pulling from the module map.
Note: The module still loaded successfully before this fix - this is specifically to mitigate the error in the console.