Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

fix(typo): circuit breaker “function” input #372

Merged
merged 1 commit into from
Nov 6, 2020

Conversation

hongbo-miao
Copy link
Contributor

@hongbo-miao hongbo-miao commented Nov 4, 2020

Description

Fix typo of the circuit breaker “function” input.

Motivation and Context

How Has This Been Tested?

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update
  • Security update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • These changes should be applied to a maintenance branch.
  • This change requires cross browser checks.
  • Performance tests should be ran against the server prior to merging.
  • This change impacts caching for client browsers.
  • This change impacts HTTP headers.
  • This change adds additional environment variable requirements for One App users.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using One App?

@hongbo-miao hongbo-miao requested a review from a team as a code owner November 4, 2020 19:49
@CLAassistant
Copy link

CLAassistant commented Nov 4, 2020

CLA assistant check
All committers have signed the CLA.

@infoxicator
Copy link
Contributor

infoxicator commented Nov 5, 2020

@hongbo-miao Thank you very much for your contribution!

@americanexpress/one-app-team before squash and merge, we need to ensure the commit message is a test instead of fix There are changes to actual code so fix is fine my bad

@hongbo-miao
Copy link
Contributor Author

You are welcome!
Nice work by the way! Learned a lot from this repo.

@nellyk nellyk merged commit e1e74b9 into americanexpress:main Nov 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants