This repository has been archived by the owner on May 3, 2024. It is now read-only.
fix(holocron-module-route): updates dep returns promises #413
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates holocron and holocron-module-route which include the following fixes:
holocron fix: moduleLoadStatus 'loading' even with no load or loadModuleData
holocron module route fix: return promises
Motivation and Context
Errors thrown when evaluating ModuleRoute properties kill the server Issue: #213
How Has This Been Tested?
Types of Changes
Checklist:
What is the Impact to Developers Using One App?