Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

fix(one-app-dev-cdn): handle uncaught promise #476

Merged
merged 1 commit into from
Apr 7, 2021
Merged

Conversation

JAdshead
Copy link
Contributor

@JAdshead JAdshead commented Apr 6, 2021

Description

update to one-app-dev-cdn which includes handling of promise created when fetching remote module map during development

Motivation and Context

Better error message when fetching invalid module map

How Has This Been Tested?

locally using valid and invalid module maps.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update
  • Security update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • These changes should be applied to a maintenance branch.
  • This change requires cross browser checks.
  • Performance tests should be ran against the server prior to merging.
  • This change impacts caching for client browsers.
  • This change impacts HTTP headers.
  • This change adds additional environment variable requirements for One App users.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using One App?

@JAdshead JAdshead requested review from a team as code owners April 6, 2021 22:55
@github-actions github-actions bot added the fix label Apr 6, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2021

📊 Bundle Size Report

file name size on disk gzip
app.js 276KB 81.5KB
runtime.js 15.6KB 5.5KB
vendors.js 124.8KB 38.3KB
app~vendors.js 430KB 112.4KB
service-worker-client.js 17.1KB 5.3KB
legacy/app.js 296.4KB 86KB
legacy/runtime.js 15.6KB 5.5KB
legacy/vendors.js 183.1KB 49.5KB
legacy/app~vendors.js 453.6KB 118.4KB
legacy/service-worker-client.js 17.6KB 5.5KB

Generated by 🚫 dangerJS against a9bea46

@nellyk nellyk merged commit 324bfa3 into main Apr 7, 2021
@nellyk nellyk deleted the fix/one-app-dev-cdn branch April 7, 2021 12:23
yeikel pushed a commit to yeikel/one-app that referenced this pull request May 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants