This repository has been archived by the owner on May 3, 2024. It is now read-only.
fix(stateConfig): use localhost rather than ip for dev #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtomcal
previously approved these changes
Mar 13, 2020
anescobar1991
force-pushed
the
bugfix/use-localhost-rather-than-ip-for-dev-state-config
branch
from
9b40e2b
to
73dc323
Compare
mtomcal
previously approved these changes
Mar 13, 2020
JamesSingleton
previously approved these changes
Mar 13, 2020
…g' of https://github.com/americanexpress/one-app into bugfix/use-localhost-rather-than-ip-for-dev-state-config
anescobar1991
dismissed stale reviews from JamesSingleton and mtomcal
via
5bbaf1a
JamesSingleton
approved these changes
Mar 13, 2020
📊 Bundle Size Report
|
Francois-Esquire
approved these changes
Mar 13, 2020
JamesSingleton
deleted the
bugfix/use-localhost-rather-than-ip-for-dev-state-config
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to start using One App Runner we need One App to make calls to the dev-proxy server using
localhostrather than the resolved IP address. The reason is that when running One App as a docker container the IP address inside that container is not resolvable by the host.Description
Updated the state config modifications we make when there is a dev.endpoints.js file to use localhost rather than the IP address
Motivation and Context
In order to start using One App Runner we need One App to make calls to the dev-proxy server using
localhostrather than the resolved IP address. The reason is that when running One App as a docker container the IP address inside that container is not resolvable by the host.How Has This Been Tested?
Unit tests were updated and made sure to run locally with parrot and a dev endpoints file.
Types of Changes
Checklist:
What is the Impact to Developers Using One App?
Allows them to use one app runner