Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

feat(intl): allow custom URLs for language packs #833

Merged
merged 1 commit into from
Oct 6, 2022

Conversation

10xLaCroixDrinker
Copy link
Member

Description

Updates one-app-ducks to v4.4.0 which includes a feature that allows users to provide a URL to fetch their language packs from instead of using the language packs generated by one-app-bundler

Motivation and Context

This enables engineers to use a CMS or other tooling to provide their language packs with the benefits gotten through using the built-in language pack feature, namely server side caching

How Has This Been Tested?

Updated cultured-frankie to point to an instance of json-server and loaded it as the root module. Manually tested out using its language switching feature watching the network tab and server logs, and of course there are new unit tests in one-app-ducks.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update
  • Security update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • These changes should be applied to a maintenance branch.
  • This change requires cross browser checks.
  • Performance tests should be ran against the server prior to merging.
  • This change impacts caching for client browsers.
  • This change impacts HTTP headers.
  • This change adds additional environment variable requirements for One App users.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using One App?

No impact for developers not using the new feature.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2022

Size Change: +209 B (0%)

Total Size: 681 kB

Filename Size Change
./build/app/app~vendors.js 387 kB +209 B (0%)
ℹ️ View Unchanged
Filename Size
./build/app/app.js 165 kB
./build/app/runtime.js 7.07 kB
./build/app/service-worker-client.js 7.26 kB
./build/app/vendors.js 114 kB

compressed-size-action

giulianok
giulianok previously approved these changes Oct 5, 2022
@10xLaCroixDrinker 10xLaCroixDrinker requested a review from a team October 5, 2022 15:38
@10xLaCroixDrinker 10xLaCroixDrinker marked this pull request as draft October 5, 2022 17:04
@10xLaCroixDrinker
Copy link
Member Author

This will need to wait for 4.4.1 to be released after americanexpress/one-app-ducks#61 is merged

@10xLaCroixDrinker 10xLaCroixDrinker requested a review from a team October 6, 2022 20:08
@10xLaCroixDrinker 10xLaCroixDrinker merged commit b67e826 into main Oct 6, 2022
@10xLaCroixDrinker 10xLaCroixDrinker deleted the feature/byo-lang-pack branch October 6, 2022 20:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants