This repository has been archived by the owner on May 3, 2024. It is now read-only.
feat(intl): allow custom URLs for language packs #833
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates one-app-ducks to v4.4.0 which includes a feature that allows users to provide a URL to fetch their language packs from instead of using the language packs generated by one-app-bundler
Motivation and Context
This enables engineers to use a CMS or other tooling to provide their language packs with the benefits gotten through using the built-in language pack feature, namely server side caching
How Has This Been Tested?
Updated cultured-frankie to point to an instance of json-server and loaded it as the root module. Manually tested out using its language switching feature watching the network tab and server logs, and of course there are new unit tests in one-app-ducks.
Types of Changes
Checklist:
What is the Impact to Developers Using One App?
No impact for developers not using the new feature.