This repository has been archived by the owner on May 3, 2024. It is now read-only.
fix(server): remove extra nodeFramework key from log entries #974
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the
"nodeFramework":"fastify"
key & value in log entries.Motivation and Context
Libraries and implementation can be tracked by the application version. Rather than an extra key in each log entry the
package-lock.json
for the tagged version, or thenode_modules
in the published image/running container can be inspected.How Has This Been Tested?
Existing tests, updated the snapshots.
Types of Changes
Checklist:
What is the Impact to Developers Using One App?
I believe very little, if any. Perhaps slightly less storage space required, though not a high concern given the verbosity of the entries.