Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

fix(server): remove extra nodeFramework key from log entries #974

Merged
merged 1 commit into from
Apr 5, 2023

Conversation

PixnBits
Copy link
Contributor

@PixnBits PixnBits commented Apr 4, 2023

Description

This PR removes the "nodeFramework":"fastify" key & value in log entries.

Motivation and Context

Libraries and implementation can be tracked by the application version. Rather than an extra key in each log entry the package-lock.json for the tagged version, or the node_modules in the published image/running container can be inspected.

How Has This Been Tested?

Existing tests, updated the snapshots.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update
  • Security update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • These changes should be applied to a maintenance branch.
  • This change requires cross browser checks.
  • Performance tests should be ran against the server prior to merging.
  • This change impacts caching for client browsers.
  • This change impacts HTTP headers.
  • This change adds additional environment variable requirements for One App users.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using One App?

I believe very little, if any. Perhaps slightly less storage space required, though not a high concern given the verbosity of the entries.

libraries and implementation can be tracked by the application version
@PixnBits PixnBits marked this pull request as ready for review April 4, 2023 21:32
@PixnBits PixnBits requested review from a team as code owners April 4, 2023 21:32
@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2023

Size Change: 0 B

Total Size: 687 kB

ℹ️ View Unchanged
Filename Size
./build/app/app.js 164 kB
./build/app/app~vendors.js 389 kB
./build/app/runtime.js 7.07 kB
./build/app/service-worker-client.js 7.26 kB
./build/app/vendors.js 120 kB

compressed-size-action

@Matthew-Mallimo Matthew-Mallimo requested a review from a team April 4, 2023 22:15
@10xLaCroixDrinker 10xLaCroixDrinker merged commit 973537c into main Apr 5, 2023
@10xLaCroixDrinker 10xLaCroixDrinker deleted the fix/logging-extra-keys branch April 5, 2023 15:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants