-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate Contact library outside Planners folder #162
Comments
Contact
library outside Planners
folder
No problem for the renaming from my side, I don't have much code to migrate and I think I'm the only one that developed in the past weeks some code in Python.
Yes there are few required changes, for instance (they might not be all of them): |
Thanks @diegoferigo. I will open a PR after https://github.com/dic-iit/bipedal-locomotion-framework/pull/142/files gets merged, and add you as one of the reviewers for the python part. |
#142 has been merged. I will proceed with the complete migration soon. |
In #142, we identified the
Contact
class to have a more generic usage extending beyond just planning.So we abstracted the current Contact class into a
ContactBase
class and implemented derived classesPlannedContact
andEstimatedContact
classes.In order to not break the current workflows and python bindings related merges, I created a new library
Contacts
and added only the above mentioned classes (See #142 (comment)).However, it would make sense to eventually move other contacts-related components from the
Contact
library that are currently existing in thePlanners
folder as well into the newContacts
folder.Consequently, we might also have to make changes in the python bindings generation? (do we? please correct me if I am wrong.)
Specifically, the changes will be
Contact
asPlannedContact
ContactList
,ContactPhase
,ContactPhaseList
to correspondingPlannedContact
equivalentsto
using namespaceContacts
cc @GiulioRomualdi @S-Dafarra @diegoferigo
The text was updated successfully, but these errors were encountered: