Fix warning in smtp binding when user and password are set (dapr#1256)

* Fix warning in smtp binding when user and password are set

* Remove nolint comment

Co-authored-by: Yaron Schneider <yaronsc@microsoft.com>
Co-authored-by: Artur Souza <artursouza.ms@outlook.com>
Co-authored-by: Dapr Bot <56698301+dapr-bot@users.noreply.github.com>
Signed-off-by: Amit Mor <amitm@at-bay.com>

Author: 4 people

bindings/smtp/smtp.go

@@ -135,11 +135,12 @@ func (s *Mailer) parseMetadata(meta bindings.Metadata) (Metadata, error) {
 		return smtpMeta, errors.New("smtp binding error: host and port fields are required in metadata")
 	}
 
-	//nolint
 	if (meta.Properties["user"] != "" && meta.Properties["password"] == "") ||
 		(meta.Properties["user"] == "" && meta.Properties["password"] != "") {
-		return smtpMeta, errors.New("smtp binding error: user and password fields are required in metadata")
-	} else {
+		return smtpMeta, errors.New("smtp binding error: both user and password fields are required in metadata")
+	}
+
+	if meta.Properties["user"] == "" && meta.Properties["password"] == "" {
 		s.logger.Warn("smtp binding warn: User and password are empty")
 	}