Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: install-dir? #271

Closed
makslevental opened this issue Aug 30, 2024 · 3 comments
Closed

feature request: install-dir? #271

makslevental opened this issue Aug 30, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@makslevental
Copy link

makslevental commented Aug 30, 2024

Any chance we could get plumbing connecting to installDir via GHA?

if ("installDir" in installationInfo) {

When I try to use this in a container on GitHub, for some reason e.g., LLVM gets deposited to /github/home/llvm.

Upvote & Fund

@aminya is using Polar.sh so you can upvote and help fund this issue. The funding is received once the issue is completed & confirmed by you.

Thank you in advance for helping prioritize & fund our backlog!


Fund with Polar
@makslevental
Copy link
Author

makslevental commented Aug 30, 2024

Actually I guess the reason is something having to do with actions/checkout#785 ?

EDIT: ah nm it's because it's in the docker startup command:

2024-08-30T23:24:43.8530158Z ##[command]/usr/bin/docker create --name 43c2dbedadf14e5aac73e8f765a2392c_quayiopypamanylinux_2_28_x86_64_ecee14 --label 5b0c62 --workdir /__w/ROCR-Runtime/ROCR-Runtime --network github_network_6777c7e75d204b20aeacf50fb1df73d8  -e "HOME=/github/home" -e GITHUB_ACTIONS=true -e CI=true -v "/var/run/docker.sock":"/var/run/docker.sock" -v "/home/runner/work":"/__w" -v "/home/runner/runners/2.319.1/externals":"/__e":ro -v "/home/runner/work/_temp":"/__w/_temp" -v "/home/runner/work/_actions":"/__w/_actions" -v "/opt/hostedtoolcache":"/__t" -v "/home/runner/work/_temp/_github_home":"/github/home" -v "/home/runner/work/_temp/_github_workflow":"/github/workflow" --entrypoint "tail" quay.io/pypa/manylinux_2_28_x86_64 "-f" "/dev/null"

@aminya aminya added the enhancement New feature or request label Sep 3, 2024
@aminya
Copy link
Owner

aminya commented Sep 5, 2024

The installation directory for binaries is always ~/ unless overwritten by SETUP_CPP_DIR. This doesn't include the installation directory for package managers that use other default paths (e.g. apt, brew)

const setupCppDir = process.env.SETUP_CPP_DIR ?? untildifyUser("~")

@makslevental
Copy link
Author

Thanks for the tip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants