feat: adds a toggle for all levels (#3321)

amir20 · Oct 11, 2024 · 5e33094 · 5e33094
1 parent 853a5d4
commit 5e33094
Show file tree

Hide file tree

Showing 4 changed files with 26 additions and 14 deletions.
diff --git a/assets/components/ContainerViewer/ContainerActionsToolbar.vue b/assets/components/ContainerViewer/ContainerActionsToolbar.vue
@@ -77,10 +77,15 @@
         </details>
       </li>
       <li>
-        <details>
+        <details class="group/details">
           <summary>
             <mdi:gauge />
             Levels
+            <Toggle
+              class="toggle-xs invisible group-open/details:visible"
+              v-model="toggleAllLevels"
+              title="Toggle all levels"
+            />
           </summary>
           <ul class="menu">
             <li v-for="level in allLevels">
@@ -169,6 +174,17 @@ const downloadUrl = computed(() =>
 );
 
 const disableRestart = computed(() => actionStates.stop || actionStates.start || actionStates.restart);
+
+const toggleAllLevels = computed({
+  get: () => levels.value.size === allLevels.length,
+  set: (value) => {
+    if (value) {
+      allLevels.forEach((level) => levels.value.add(level));
+    } else {
+      levels.value.clear();
+    }
+  },
+});
 </script>
 
 <style scoped lang="postcss">

diff --git a/assets/components/common/Toggle.vue b/assets/components/common/Toggle.vue
@@ -4,7 +4,7 @@
       <slot />
     </template>
     <template #input>
-      <input type="checkbox" class="toggle toggle-primary" v-model="modelValue" />
+      <input type="checkbox" class="toggle toggle-primary" v-model="modelValue" v-bind="$attrs" />
     </template>
   </LabeledInput>
 </template>

diff --git a/internal/web/logs.go b/internal/web/logs.go
@@ -142,12 +142,8 @@ func (h *handler) fetchLogsBetweenDates(w http.ResponseWriter, r *http.Request)
 	}
 
 	levels := make(map[string]struct{})
-	if r.URL.Query().Has("levels") {
-		for _, level := range r.URL.Query()["levels"] {
-			levels[level] = struct{}{}
-		}
-	} else {
-		levels = docker.SupportedLogLevels
+	for _, level := range r.URL.Query()["levels"] {
+		levels[level] = struct{}{}
 	}
 
 	encoder := json.NewEncoder(w)
@@ -287,12 +283,8 @@ func streamLogsForContainers(w http.ResponseWriter, r *http.Request, multiHostCl
 	backfill := make(chan []*docker.LogEvent)
 
 	levels := make(map[string]struct{})
-	if r.URL.Query().Has("levels") {
-		for _, level := range r.URL.Query()["levels"] {
-			levels[level] = struct{}{}
-		}
-	} else {
-		levels = docker.SupportedLogLevels
+	for _, level := range r.URL.Query()["levels"] {
+		levels[level] = struct{}{}
 	}
 
 	if r.URL.Query().Has("filter") {

diff --git a/internal/web/logs_test.go b/internal/web/logs_test.go
@@ -28,6 +28,7 @@ func Test_handler_streamLogs_happy(t *testing.T) {
 	q := req.URL.Query()
 	q.Add("stdout", "true")
 	q.Add("stderr", "true")
+	q.Add("levels", "info")
 
 	req.URL.RawQuery = q.Encode()
 	require.NoError(t, err, "NewRequest should not return an error.")
@@ -70,6 +71,7 @@ func Test_handler_streamLogs_happy_with_id(t *testing.T) {
 	q := req.URL.Query()
 	q.Add("stdout", "true")
 	q.Add("stderr", "true")
+	q.Add("levels", "info")
 
 	req.URL.RawQuery = q.Encode()
 	require.NoError(t, err, "NewRequest should not return an error.")
@@ -218,6 +220,7 @@ func Test_handler_between_dates(t *testing.T) {
 	q.Add("to", to.Format(time.RFC3339))
 	q.Add("stdout", "true")
 	q.Add("stderr", "true")
+	q.Add("levels", "info")
 
 	req.URL.RawQuery = q.Encode()
 
@@ -258,6 +261,7 @@ func Test_handler_between_dates_with_fill(t *testing.T) {
 	q.Add("stdout", "true")
 	q.Add("stderr", "true")
 	q.Add("fill", "true")
+	q.Add("levels", "info")
 
 	req.URL.RawQuery = q.Encode()