Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment succeeds but workflow reports failure #12

Closed
brandiqa opened this issue Dec 10, 2019 · 3 comments
Closed

Deployment succeeds but workflow reports failure #12

brandiqa opened this issue Dec 10, 2019 · 3 comments
Labels
Type: Question Further information is requested

Comments

@brandiqa
Copy link

brandiqa commented Dec 10, 2019

I have a static website am trying to deploy using GitHub actions. I've copied the workflow provided https://github.com/marketplace/actions/zeit-now-deployment.

Despite the deployment being successful, GitHub displays annotations errors:

annotation-errors

Edit
I have a deadline to complete this project. Hence I'll need to remove the zeit deploy workflow and switch to deployment via Zeit GitHub integration. Here's the deployment GitHub Action for reference:

name: Deploy static website

on: [push]

jobs:
  deploy:

    runs-on: ubuntu-latest

    steps:
      - uses: actions/checkout@v1
      - uses: amondnet/now-deployment@v1
        with:
          github-token: ${{ secrets.GITHUB_TOKEN }}
          zeit-token: ${{ secrets.ZEIT_TOKEN }}
          zeit-team-id: team_XXXXXXXXXXX
          now-args: '--prod'
@amondnet
Copy link
Owner

amondnet commented Dec 11, 2019

@brandiqa
team_XXXXXXXXXXX is example value and not your team id. If you delete it, it will work normally.

zeit-team-id
This is required if your deployment is made on zeit team project.

name: Deploy static website

on: [push]

jobs:
  deploy:

    runs-on: ubuntu-latest

    steps:
      - uses: actions/checkout@v1
      - uses: amondnet/now-deployment@v1
        with:
          github-token: ${{ secrets.GITHUB_TOKEN }}
          zeit-token: ${{ secrets.ZEIT_TOKEN }}
          now-args: '--prod'

@amondnet amondnet added the Type: Question Further information is requested label Dec 11, 2019
@amondnet
Copy link
Owner

amondnet commented Dec 11, 2019

@brandiqa If it doesn't work after editing, please let me know.

@brandiqa
Copy link
Author

brandiqa commented Dec 11, 2019

It worked! thanks for the assistance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants