Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not want to receive comments from action #14

Closed
nb5p opened this issue Dec 26, 2019 · 4 comments · Fixed by #20
Closed

Do not want to receive comments from action #14

nb5p opened this issue Dec 26, 2019 · 4 comments · Fixed by #20
Assignees
Labels
Type: Feature New Feature

Comments

@nb5p
Copy link

nb5p commented Dec 26, 2019

Hello, I used this action, it is very convenient to replace now bot. I don't want to receive comments under commit every time I deploy to now. I removed github-token and it can be deployed to now, but ci reports an error. I hope that github-token can be turned into an optional item.

@amondnet amondnet self-assigned this Dec 30, 2019
@amondnet amondnet added the Type: Feature New Feature label Dec 30, 2019
@amondnet
Copy link
Owner

@nb5p Hi, thank you for your good feedback. I will work on it next week.

@sergeyfilimonov
Copy link

@amondnet same here, I removed GitHub token but every time I get ##[error]Bad credentials ##[error]Node run failed with exit code 1 though the app deploys well on Zeit.

@amondnet
Copy link
Owner

@nb5p @sergeyfilimonov

github-token is now optional.

- uses: amondnet/now-deployment@v1
  with:
    zeit-token: ${{ secrets.ZEIT_TOKEN }}

@sergeyfilimonov
Copy link

@amondnet the error is gone! thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New Feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants