Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

team_id seems to be not working #19

Closed
sergeyfilimonov opened this issue Jan 26, 2020 · 1 comment · Fixed by #38
Closed

team_id seems to be not working #19

sergeyfilimonov opened this issue Jan 26, 2020 · 1 comment · Fixed by #38
Assignees
@amondnet
Labels
Type: Feature New Feature

Comments

@sergeyfilimonov
Copy link

sergeyfilimonov commented Jan 26, 2020 •
edited
Loading

Specifying team_id under zeit-team-id has no effect. Unless I indicate scope in now.json it's not choosing the right team. So I tried to remove zeit-team-id from my deploy.yaml and it still deploys well under the right scope. I would suggest to remove the requirement of zeit-team-id and recommend using only now.json to set a scope.
@amondnet
Copy link
Owner

amondnet commented Jan 28, 2020 •
edited
Loading

now-deployment/index.js

Line 21 in c334a92

teamId: zeitTeamId || undefined,

zeit-team-id is required for comment( find deployment ), not deployment. The deployment will work normally without the zeit-team-id.

I will find a better way or make the comment optional (#20 ).

@amondnet amondnet self-assigned this Jan 28, 2020
@amondnet amondnet added the Type: Feature New Feature label Feb 18, 2020
@amondnet amondnet mentioned this issue Mar 23, 2020
Closed
@amondnet amondnet linked a pull request Apr 4, 2020 that will close this issue
Fix empty output object #38
Merged
@amondnet amondnet closed this as completed Apr 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amondnet amondnet

Labels
Type: Feature New Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix empty output object
2 participants
@amondnet @sergeyfilimonov