Branch is undefined

[ckipp01]

Hello! Thanks for the great action. I've noticed that when I check in the Zeit Dashboard, the branch name is undefined that caused the deployment. Am I potentially missing something, or is this just not being set?

My setup:

      - name: Zeit Now Deployment
        uses: amondnet/now-deployment@v2.0.0
        with:
          zeit-token: ${{ secrets.ZEIT_TOKEN }}
          now-org-id: ${{ secrets.ORG_ID }}
          now-project-id: ${{ secrets.PROJECT_ID }}
          now-args: '--prod'

Everything deploys correctly, but you can see in the deployments page that the commit message is there, but no branch name

Then when you click into the deployment, you'll again see the missing branch name that leads you to tree/undefined which will obviously 404 on github.

[ckipp01]

Looking at it, my naive thought is that there is a missing key here:

now-deployment/index.js

Lines 80 to 104 in 1defb91

	return await exec.exec('npx', [
	'now',
	...(nowArgs.split(/ +/)),
	'-t',
	zeitToken,
	'-m',
	`githubCommitSha=${context.sha}`,
	'-m',
	`githubCommitAuthorName=${context.actor}`,
	'-m',
	`githubCommitAuthorLogin=${context.actor}`,
	'-m',
	'githubDeployment=1',
	'-m',
	`githubOrg=${context.repo.owner}`,
	'-m',
	`githubRepo=${context.repo.repo}`,
	'-m',
	`githubCommitOrg=${context.repo.owner}`,
	'-m',
	`githubCommitRepo=${context.repo.repo}`,
	'-m',
	`githubCommitMessage=${commit}`], options).then(() => {
	})
	}

However, I'm unable to quickly find it in the Zeit Deployment api docs.

[amondnet]

@ckipp01
I think githubCommitRef needs to be added.
Can you tell me if branch is displayed after setting like below?

      - name: Zeit Now Deployment
        uses: amondnet/now-deployment@v2.0.0
        with:
          zeit-token: ${{ secrets.ZEIT_TOKEN }}
          now-org-id: ${{ secrets.ORG_ID }}
          now-project-id: ${{ secrets.PROJECT_ID }}
          now-args: '--prod -m githubCommitRef=YOUR_BRANCH' #-m githubCommitRef=YOUR_BRANCH

[ckipp01]

Just tested. 👍 the branch appears when that is filled in.

[amondnet]

@ckipp01 Thank you. I will fix it in the next release(v2.0.2).