Skip to content

Commit e799cbc

Browse files
committedMay 17, 2019
Fix outdated rubocop, contrain on rake to pass reek
1 parent 22f5f85 commit e799cbc

File tree

4 files changed

+8
-7
lines changed

4 files changed

+8
-7
lines changed
 

‎.rubocop.yml

+3-3
Original file line numberDiff line numberDiff line change
@@ -3,15 +3,15 @@ AllCops:
33
- '**/Rakefile'
44
Exclude:
55
- 'spec/**/*'
6-
Style/LineLength:
6+
Metrics/LineLength:
77
Max: 99
8-
Style/FileName:
8+
Naming/FileName:
99
Enabled: false
1010
Style/ModuleFunction:
1111
Enabled: false
1212
Style/Encoding:
1313
Enabled: false
1414
Documentation:
1515
Enabled: false
16-
Style/MethodLength:
16+
Metrics/MethodLength:
1717
Max: 15

‎Gemfile

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,4 +17,4 @@ group :local_development do
1717
gem 'guard-cane', require: false
1818
gem 'guard-reek', github: 'pericles/guard-reek', require: false
1919
gem 'pry'
20-
end
20+
end

‎Rakefile

+3-2
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
# frozen_string_literal: true
2+
13
require 'bundler/gem_tasks'
24
require 'rspec/core/rake_task'
35

@@ -9,13 +11,12 @@ RuboCop::RakeTask.new(:rubocop)
911

1012
# reek
1113
require 'reek/rake/task'
12-
1314
Reek::Rake::Task.new do |t|
1415
t.fail_on_error = false
1516
t.source_files = Dir['lib/**/*.rb']
1617
end
1718

18-
default_tasks = [:spec, :rubocop, :reek]
19+
default_tasks = %i[spec rubocop reek]
1920

2021
unless defined? ::Rubinius
2122
# cane

‎pipedrive.gemspec

+1-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ Gem::Specification.new do |gem|
2323
gem.add_dependency('activesupport', '>= 4.0.0')
2424
gem.add_dependency('hashie', '>= 3.0')
2525
gem.add_development_dependency('bundler')
26-
gem.add_development_dependency('rake')
26+
gem.add_development_dependency('rake', '< 12')
2727
gem.add_development_dependency('rspec', '>= 3.0')
2828
gem.add_development_dependency('rubocop')
2929
gem.add_development_dependency('reek')

0 commit comments

Comments
 (0)