Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sftp-deployment (1 deprecation) atom.workspace.paneContainer #149

Open
adrianvanlan opened this issue Nov 16, 2017 · 3 comments
Open

sftp-deployment (1 deprecation) atom.workspace.paneContainer #149

adrianvanlan opened this issue Nov 16, 2017 · 3 comments

Comments

@adrianvanlan
Copy link

sftp-deployment (1 deprecation)
atom.workspace.paneContainer has always been private, but it is now gone. Please use atom.workspace.getCenter() instead and consult the workspace API docs for public methods.

Workspace.get - :28210:18
FileManager.getCurrentFile - /home/user/.atom/packages/SFTP-deployment/lib/filesystem/FileManager.js:31:49
HTMLElement.DeploymentManager.uploadCurrentFile - /home/user/.atom/packages/SFTP-deployment/lib/DeploymentManager.js:217:18
CommandRegistry.handleCommandEvent - :22275:36
KeymapManager.dispatchCommandEvent - :68125:22
KeymapManager.handleKeyboardEvent - :67916:28

@christophgockel
Copy link

This is a duplicate of #147 and I'm copying my response from there:

Unfortunately, according to the issues and PRs, this repo seems stale. Not sure what @amoussard thinks of it, but I've picked it up as a fork and merged one PR into it already.
In case you're interested, you can check it out here: https://github.com/christophgockel/atom-sftp-sync

I tried several SFTP syncing plugins and they all seemed outdated/non-maintained. Sftp-deployment had exactly the features I was looking for. The plugin linked above is ready for atom 1.20 now with the majority of feature working again - at least the parts I needed at the moment.

@adrianvanlan You can try my forked version and see if that helps you.

@leomp12
Copy link

leomp12 commented Nov 20, 2017

@christophgockel I tried your fork, but some features still not working in Atom 1.21+ (now I'm using 1.22), it was few weeks ago so I can't remember what was the problems, sorry about that.
I solved the problems (few weeks ago too) just editing the package files on my computer, so I don't published a new fork (laziness :p), but today I've maked a pull request, if you wan't to check:
#150

I think it will solve your problems @adrianvanlan

@christophgockel
Copy link

christophgockel commented Nov 20, 2017

Thanks @leomp12! Can you elaborate on what features exactly don't work for you and for what type of connection (e.g. FTP or SFTP)?
I'm using Atom 1.22.1 just fine with atom-sftp-sync version 2.0.1. But to be honest the majority of fixes that went into my fork so far made sure that SFTP upload and download of files and directories is working correctly again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants