Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is dialog a drop in replacement for timbre API ? #13

Closed
ieugen opened this issue Nov 3, 2022 · 2 comments
Closed

Is dialog a drop in replacement for timbre API ? #13

ieugen opened this issue Nov 3, 2022 · 2 comments
Assignees
Labels
question Further information is requested

Comments

@ieugen
Copy link
Contributor

ieugen commented Nov 3, 2022

Hi,

We are using timbre and looking at dialog because we can't have unified logging with timbre.
We are using slf4j-timbre but I can't filter out apache loggers.
Also the library is not in sync with timbre and there is also fzakaria/slf4j-timbre#40 .

p.s. Implementing slf4j API I don't expect dialog to work in CLJS as timbre does.

@greglook greglook added the question Further information is requested label Nov 3, 2022
@greglook greglook self-assigned this Nov 3, 2022
@greglook
Copy link
Contributor

greglook commented Nov 3, 2022

Depends on how you're consuming Timbre - dialog provides the same set of trace/debug/info/warn/error/fatal "print" loggers as well as the corresponding infof etc "format" loggers. This also matches the API provided by clojure.tools.logging, so if you're using that style of logging then things shouldn't need much if any changes.

For more structured logging, you'd use dialog.logger/log-event to provide maps with key/value entries, some of which are the standard :level, :logger, :message, etc. This is the equivalent of timbre/log! function, if I am reading the code correctly.

@ieugen
Copy link
Contributor Author

ieugen commented Nov 4, 2022

I found that dialog.logger does not contain log or spy from timbre.

@greglook greglook closed this as completed Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants