icons.ts could be rewritten for readability and maintenance

[simonaubertbd]

Hello,

There are several files icon.ts with code like this :

import { LabIcon } from '@jupyterlab/ui-components';

import redditIconSvgStr from '../style/icons/reddit.svg';
import trinoIconSvgStr from '../style/icons/trino.svg'
import chromaSvgStr from '../style/icons/chroma.svg'
import ollamaIconSvgStr from '../style/icons/ollama.svg'
import pineconeIconSvgStr from '../style/icons/pinecone.svg';
import changeCircleIconSvgStr from '../style/icons/change-circle-24.svg';
import sortIconSvgStr from '../style/icons/sort-desc-24.svg';
import MarkdownSvgStr from '../style/icons/markdown-fill.svg';
import openAiSvgStr from '../style/icons/openai.svg';
import htmlLineSvgStr from '../style/icons/html-line.svg';
import apiIconSvgStr from '../style/icons/api-24.svg';
import splitIconSvgStr from '../style/icons/scissors-24.svg';
import boxIconSvgStr from '../style/icons/box-16.svg';
import engineIconSvgStr from '../style/icons/service-16.svg'
import settingsIconSvgStr from '../style/icons/settings-16.svg';
import playCircleIconSvgStr from '../style/icons/play-circle-16.svg';


export const apiIcon = new LabIcon({
  name: 'amphi:api-icon',
  svgstr: apiIconSvgStr
});

export const sortIcon = new LabIcon({
  name: 'amphi:sortIcon',
  svgstr: sortIconSvgStr
});

export const splitIcon = new LabIcon({
  name: 'amphi:splitIcon',
  svgstr: splitIconSvgStr
});

export const boxIcon = new LabIcon({
  name: 'amphi:box-icon',
  svgstr: boxIconSvgStr
});

export const redditIcon = new LabIcon({
  name: 'amphi:redditIcon',
  svgstr: redditIconSvgStr
});

export const openAiIcon = new LabIcon({
  name: 'amphi:openAiIcon',
  svgstr: openAiSvgStr
});

export const settingsIcon = new LabIcon({
  name: 'amphi:settings-config-icon',
  svgstr: settingsIconSvgStr
});

export const pineconeIcon = new LabIcon({
  name: 'amphi:pinecone-icon',
  svgstr: pineconeIconSvgStr
});

export const changeCircleIcon = new LabIcon({
  name: 'amphi:changeCircle-icon',
  svgstr: changeCircleIconSvgStr
});

export const markdownIcon = new LabIcon({
  name: 'amphi:markdown-icon',
  svgstr: MarkdownSvgStr
});

export const htmlLineIcon = new LabIcon({
  name: 'amphi:htmlLine-icon',
  svgstr: htmlLineSvgStr
});

export const chromaIcon = new LabIcon({
  name: 'amphi:chroma-icon',
  svgstr: chromaSvgStr
});


export const playCircleIcon = new LabIcon({
  name: 'amphi:play-circle-icon',
  svgstr: playCircleIconSvgStr
});


export const trinoIcon = new LabIcon({
  name: 'amphi:trino-icon',
  svgstr: trinoIconSvgStr
});


export const engineIcon = new LabIcon({
  name: 'amphi:engine-icon',
  svgstr: engineIconSvgStr
});

export const ollamaIcon = new LabIcon({
  name: 'amphi:ollama-icon',
  svgstr: ollamaIconSvgStr
});

I think that a loop could help and reduce drastically the code

Best regards,

Simon

[tgourdel]

That's a good idea :)