Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error when set BodySizeLimit to 0 with http2 #296

Closed
xpader opened this issue Sep 14, 2021 · 0 comments · Fixed by #297
Closed

Error when set BodySizeLimit to 0 with http2 #296

xpader opened this issue Sep 14, 2021 · 0 comments · Fixed by #297

Comments

@xpader
Copy link
Contributor

xpader commented Sep 14, 2021 •
edited
Loading

When setBodySizeLimit to 0 (means no limit) and send request with http2 protocol, will see this error:

Amp\Http\Client\Connection\Http2StreamException: Body size limit exceeded in /.../vendor/amphp/http-client/src/Connection/Internal/Http2ConnectionProcessor.php:782

https://github.com/amphp/http-client/blob/master/src/Connection/Internal/Http2ConnectionProcessor.php#L838
@xpader xpader mentioned this issue Sep 14, 2021
Merged
@xpader xpader changed the title Unable to set BodySizeLimit to 0 with http2 Error when set BodySizeLimit to 0 with http2 Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix setBodySizeLimit(0) with HTTP/2 protocol xpader/http-client
1 participant
@xpader