Infinite polling without interval if flagConfigPollingIntervalMillis is not explicitly set

[pdhoopr]

Hi there,

It looks like #141 introduced a configurable option for the flag polling interval with the intention that it would fall back to the default of 5 minutes if the option was not explicitly set. However after upgrading, I'm seeing that if I don't explicitly configure the new flagConfigPollingIntervalMillis option, then our app sends an infinite, rapid amount of polling requests without any timeout in between.

Looking through the PR, the interval value is computed and saved to the ExperimentClient config here, but the value passed to the poller here is actually the un-computed value from the config object passed to the constructor. So presumably the following change would work, if I'm following correctly:

    this.poller = new Poller(
      () => this.doFlags(),
-      config.flagConfigPollingIntervalMillis,
+      this.config.flagConfigPollingIntervalMillis,
    );

Thanks in advance for your help!

[bgiori]

Thanks! Fixed in @amplitude/experiment-js-client@1.13.2 🙏