Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP SDK improvements #10

Closed
adri opened this issue Nov 29, 2023 · 2 comments
Closed

PHP SDK improvements #10

adri opened this issue Nov 29, 2023 · 2 comments

Comments

@adri
Copy link

adri commented Nov 29, 2023 •
edited
Loading

We're evaluating the PHP SDK and found a few issues we see with this package:

  • Depends directly on Guzzle, instead use php-http/discovery. This allows people to use their own compatible client.
  • Depends on Monolog, instead use a PSR Log. You can suggest monolog
  • Run tests run on a (recent) PHP version matrix, not just 7.4 (this version and 8.0 is unsupported)
  • Use phpstan
  • 2 days ago lastguest/murmurhash was pulled in that's 6 years old, 2 years last commit. The SDK should require minimum deps.
@bgiori
Copy link
Collaborator

bgiori commented Dec 11, 2023

Thanks @adri! Appreciate your expertise here.

@tyiuhc tyiuhc mentioned this issue Dec 29, 2023
Merged
@ruudk
Copy link
Contributor

ruudk commented Feb 6, 2024

With the merge of #13 this can be closed 🎉

@tyiuhc tyiuhc closed this as completed Feb 6, 2024
@ruudk ruudk mentioned this issue Sep 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ruudk @adri @bgiori @tyiuhc