Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need to setup GitHub action to test amp script minification by the optional package Peast #315

Open
ediamin opened this issue Aug 13, 2021 · 0 comments
Open

Need to setup GitHub action to test amp script minification by the optional package Peast #315

ediamin opened this issue Aug 13, 2021 · 0 comments
Labels
Minification Testing Issues related with Unit, E2E, Smoke, and other testing requirements/needs

Comments

@ediamin
Copy link
Collaborator

ediamin commented Aug 13, 2021

To minify the amp scripts, we are using Peast as an optional package dependency. So the code related to minify the script is being ignored from the coverage report. This could be handled by a new GitHub action that include Peast before we generate the coverage report.

Related to #281 (comment)
@ediamin ediamin mentioned this issue Aug 13, 2021
Merged
@schlessera schlessera added Minification Testing Issues related with Unit, E2E, Smoke, and other testing requirements/needs labels Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Minification Testing Issues related with Unit, E2E, Smoke, and other testing requirements/needs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@schlessera @ediamin