-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more support for SVG related self-closing tags in Document filter #405
Comments
If browsers properly handle the parsing of self-closing SVG tags in HTML the same way as empty SVG tags, then I suppose there's no need to go further here. |
Yes, there's no technical need from the browser's point of view. But for the sake of consistency and for being able to build reliable tests against anything that includes SVGs, it would be preferable to have a clean normalization of these tags that we can test against. No immediate action needed here for now, we just wanted to ensure this is not lost in case we need to revisit. |
There are many empty elements in SVG than just
circle
,g
andpath
tags. For example:use
rect
image
polygon
ellipse
Technically in SVG (as XML), any element can be self-closing, even if they aren't defined as empty (e.g.
g
).Should this not be comprehensive? Or is it exclusively just to make the tests pass?
cf. ampproject/amp-wp#6657 (comment)
Originally posted by @westonruter in #210 (comment)
The text was updated successfully, but these errors were encountered: