Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gutenberg] Introduction of new blocks for AMP specific features #1039

Closed
postphotos opened this issue Mar 22, 2018 · 6 comments
Closed

[Gutenberg] Introduction of new blocks for AMP specific features #1039

postphotos opened this issue Mar 22, 2018 · 6 comments

Comments

@postphotos
Copy link
Contributor

Possibly to be included in v1.0 release. Formal story + AC to come soon.

@postphotos postphotos changed the title [gutenberg] Introduction of new blocks for AMP specific features [Gutenberg] Introduction of new blocks for AMP specific features Mar 22, 2018
@westonruter
Copy link
Member

westonruter commented Apr 18, 2018

Regarding amp-carousel see #1065. I do not recommend there being an amp-carousel block in itself to, for example, allow the user to create an arbitrary carousel of other blocks (like the experimental Columns block with nested blocks). We can limit the scope for amp-gallery to just be an extension to the Gallery block, similar to what is done in Jetpack I believe.

@westonruter
Copy link
Member

All Gutenberg PRs have been merged, so I believe this is now ready for QA.

@kienstra
Copy link
Contributor

kienstra commented Jun 6, 2018

Request For Testing

Hi @csossi,
Could you please test this?

  1. Go to https://native-ampconfdemo.pantheonsite.io/
  2. Create a new post
  3. Test all of the AMP blocks, which will show when you search for "AMP"

amp-blocks

  1. Often, there are example IDs or values in the site ampbyexample.com. Like if you need an ID to test the AMP Reach Player, you could go to https://ampbyexample.com/components/amp-reach-player/ and use its data-embed-id value.

  2. Expected: The blocks render properly on the front-end. The media players won't render the media in the editor, but they will on the front-end.

@csossi
Copy link

csossi commented Jun 7, 2018

@kienstra Could be "ok as is", but not seeing anything on the front end for the springboard player, and can't seem to find ids for the ooyala player. Post is https://native-ampconfdemo.pantheonsite.io/2018/06/07/qa-test-post/

@csossi csossi assigned kienstra and unassigned miina and csossi Jun 7, 2018
@kienstra
Copy link
Contributor

kienstra commented Jun 7, 2018

Thanks For Testing
I Also Saw Your 2 Points

Hi @csossi,
Thanks for testing this.

  1. I also saw that the amp-springboard-player doesn't display on the front-end:

amp-springboard-player

But the values that the AMP by Example site gives don't even cause the player to render on that page:
https://ampbyexample.com/components/amp-springboard-player/
After a brief search, I couldn't find any other values for this. We might revisit this for later, but I'd propose that it's alright for now.

  1. Good point, it's hard to find IDs for the Ooyala player. I copied the ones from this doc into the editor, and they seem to display well:

ooyala-player

@kienstra kienstra removed their assignment Jun 7, 2018
@miina
Copy link
Contributor

miina commented Jun 8, 2018

Hey @kienstra, thanks for looking into this, let me know if that's something that would be good if I would investigate (springboard player issue).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants