-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Confirm the "comments" content still validates on output. #1053
Comments
Here is HTML which can be pasted into the validator to check if it passes: <!doctype html>
<html ⚡>
<head>
<meta charset="utf-8">
<link rel="canonical" href="self.html" />
<meta name="viewport" content="width=device-width,minimum-scale=1">
<style amp-boilerplate>body{-webkit-animation:-amp-start 8s steps(1,end) 0s 1 normal both;-moz-animation:-amp-start 8s steps(1,end) 0s 1 normal both;-ms-animation:-amp-start 8s steps(1,end) 0s 1 normal both;animation:-amp-start 8s steps(1,end) 0s 1 normal both}@-webkit-keyframes -amp-start{from{visibility:hidden}to{visibility:visible}}@-moz-keyframes -amp-start{from{visibility:hidden}to{visibility:visible}}@-ms-keyframes -amp-start{from{visibility:hidden}to{visibility:visible}}@-o-keyframes -amp-start{from{visibility:hidden}to{visibility:visible}}@keyframes -amp-start{from{visibility:hidden}to{visibility:visible}}</style><noscript><style amp-boilerplate>body{-webkit-animation:none;-moz-animation:none;-ms-animation:none;animation:none}</style></noscript>
<script async src="https://cdn.ampproject.org/v0.js"></script>
<script async custom-element="amp-live-list" src="https://cdn.ampproject.org/v0/amp-live-list-0.1.js"></script>
</head>
<body>
<amp-live-list id="my-live-list" data-poll-interval="15000" data-max-items-per-page="20" sort="ascending">
<button update on="tap:my-live-list.update">You have updates!</button>
<div items></div>
<!-- pagination is optional -->
<div pagination></div>
</amp-live-list>
</body>
</html> This issue can be closed when there is no longer a validation error reported as follows: |
Probably should be tested once ampproject/amphtml#13552 is closed. |
Next week is the current ETA on this. See ampproject/amphtml#5396 (comment) |
Error Still Exists Pasting the snippet from @westonruter's comment above in the validator still causes the same validation failure. |
Validation error is still present. |
This is now live! |
As a result of amp-live-list changes and as a part of the
v0.7
Beta 2 release, we want to confirm comments work as expected in WordPress.Also when comments are in ascending order (oldest comments at top) the AMPConf theme's single template should validate via validator.ampproject.org when the
amp-live-list
hassort=ascending
.This note is for QA to check PR #1024 works as expected.
The text was updated successfully, but these errors were encountered: