Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirm the "comments" content still validates on output. #1053

Closed
postphotos opened this issue Apr 3, 2018 · 6 comments
Closed

Confirm the "comments" content still validates on output. #1053

postphotos opened this issue Apr 3, 2018 · 6 comments
Milestone

Comments

@postphotos
Copy link
Contributor

As a result of amp-live-list changes and as a part of the v0.7 Beta 2 release, we want to confirm comments work as expected in WordPress.

Also when comments are in ascending order (oldest comments at top) the AMPConf theme's single template should validate via validator.ampproject.org when the amp-live-list has sort=ascending.

This note is for QA to check PR #1024 works as expected.

@westonruter westonruter added this to the v0.7 milestone Apr 3, 2018
@westonruter
Copy link
Member

Here is HTML which can be pasted into the validator to check if it passes:

<!doctype html>
<html >
<head>
  <meta charset="utf-8">
  <link rel="canonical" href="self.html" />
  <meta name="viewport" content="width=device-width,minimum-scale=1">
  <style amp-boilerplate>body{-webkit-animation:-amp-start 8s steps(1,end) 0s 1 normal both;-moz-animation:-amp-start 8s steps(1,end) 0s 1 normal both;-ms-animation:-amp-start 8s steps(1,end) 0s 1 normal both;animation:-amp-start 8s steps(1,end) 0s 1 normal both}@-webkit-keyframes -amp-start{from{visibility:hidden}to{visibility:visible}}@-moz-keyframes -amp-start{from{visibility:hidden}to{visibility:visible}}@-ms-keyframes -amp-start{from{visibility:hidden}to{visibility:visible}}@-o-keyframes -amp-start{from{visibility:hidden}to{visibility:visible}}@keyframes -amp-start{from{visibility:hidden}to{visibility:visible}}</style><noscript><style amp-boilerplate>body{-webkit-animation:none;-moz-animation:none;-ms-animation:none;animation:none}</style></noscript>
  <script async src="https://cdn.ampproject.org/v0.js"></script>
  <script async custom-element="amp-live-list" src="https://cdn.ampproject.org/v0/amp-live-list-0.1.js"></script>
</head>
<body>
  <amp-live-list id="my-live-list" data-poll-interval="15000" data-max-items-per-page="20" sort="ascending"> 
    <button update on="tap:my-live-list.update">You have updates!</button>
    <div items></div>
    <!-- pagination is optional -->
    <div pagination></div>
  </amp-live-list>
</body>
</html>

This issue can be closed when there is no longer a validation error reported as follows:

image

@westonruter
Copy link
Member

Probably should be tested once ampproject/amphtml#13552 is closed.

@westonruter
Copy link
Member

Next week is the current ETA on this. See ampproject/amphtml#5396 (comment)

@kienstra
Copy link
Contributor

kienstra commented Apr 9, 2018

Error Still Exists

Pasting the snippet from @westonruter's comment above in the validator still causes the same validation failure.

@westonruter
Copy link
Member

Validation error is still present.

@westonruter
Copy link
Member

This is now live!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants