Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The tag 'amp-anim' requires including the 'amp-anim' extension JavaScript. #1090

Closed
jonhendershot opened this issue Apr 20, 2018 · 8 comments
Milestone

Comments

@jonhendershot
Copy link

Google Search Console is returning this issue for makup on our site.

The tag 'amp-anim' requires including the 'amp-anim' extension JavaScript.

Worth noting that we're using code on branch v0.7 as per your recommendation in ticket #1076

screen shot 2018-04-20 at 1 46 55 pm

@westonruter
Copy link
Member

@jonhendershot Please share the URL for the page in question.

@jonhendershot
Copy link
Author

@westonruter
Copy link
Member

@jonhendershot so the GIF is used as the featured image here of the post, correct?

@westonruter
Copy link
Member

@jonhendershot ah, you caught a bug in 0.7! Fix submitted in #1092.

@westonruter westonruter added this to the v0.7 milestone Apr 20, 2018
@westonruter
Copy link
Member

@jonhendershot please give the 0.7 branch a try now.

@jonhendershot
Copy link
Author

jonhendershot commented Apr 23, 2018

hi @westonruter -- similar to our other ticket, we're still seeing the same issues after updating the plugin.

url for staging:
https://amp-slides-well-good.pantheonsite.io/good-sweat/sky-ting-yoga-brooklyn-expansion/amp/

meta tag in head:
<meta name="generator" content="AMP Plugin v0.7-beta1-d65578d-20180420T213729Z" />

@westonruter
Copy link
Member

@jonhendershot The commit d65578d you have in your generator indicates that it does not include the merged fix:

image

We released 07-RC1 so you can just use the pre-release ZIP build as opposed to creating a new one yourself: https://github.com/Automattic/amp-wp/releases/download/0.7-RC1/amp.zip

@jonhendershot
Copy link
Author

ah! grabbing it now & will report back. Thanks @westonruter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants