Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amp plugin causing inability to view posts #1130

Closed
ppcguyorlando opened this issue May 7, 2018 · 3 comments
Closed

amp plugin causing inability to view posts #1130

ppcguyorlando opened this issue May 7, 2018 · 3 comments

Comments

@ppcguyorlando
Copy link

When I click on edit link of post, I am taken to blank screen. We have deactivated the plugin..any resolution. when deactivated, we can see blog post contents...when activated, see this image.
screen shot 2018-05-07 at 12 23 19 pm

@westonruter
Copy link
Member

westonruter commented May 7, 2018

There may be a PHP error occurring. Can you share your PHP error log? Otherwise, can you add define( 'WP_DEBUG', true ); to your wp-config.php?

If I had to guess, I would say that the the issue may be coming from these lines:

https://github.com/Automattic/amp-wp/blob/5ab7f0840a2b0735e6e982b8d3a3c4376d449075/includes/utils/class-amp-validation-utils.php#L555-L567

Specifically, the process_markup does apply_filters( 'the_content', ... ):

https://github.com/Automattic/amp-wp/blob/5ab7f0840a2b0735e6e982b8d3a3c4376d449075/includes/utils/class-amp-validation-utils.php#L378

So you could have a plugin that is not liking this.

Please also share the list of plugins you have active. In particular, share any plugin or theme that has mentions the_content.

@westonruter
Copy link
Member

westonruter commented May 7, 2018

@ppcguyorlando based on the hunch of the_content filter, I've opened a PR to rework that. Would you be able to test the build? See #1132. To test:

git clone --recursive https://github.com/Automattic/amp-wp.git amp
cd amp
npm install
composer install
npm run build

This will create an amp.zip file that you can install on your site. Note you'll have to first deactivate and uninstall the v0.7.0 AMP plugin before you can upload and activate this ZIP on the plugins admin screen. Ideally you could test this on a staging site.

@westonruter
Copy link
Member

westonruter commented Jun 24, 2018

This should be fixed now as of 0.7.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants